Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update bazel to 0.24 #29530

Closed
wants to merge 1 commit into from
Closed

build: update bazel to 0.24 #29530

wants to merge 1 commit into from

Conversation

alexeagle
Copy link
Contributor

Note, this decreases the size from 140M to 93M which should help with some of our yarn no output in 10m errors on CI

@alexeagle alexeagle added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release labels Mar 27, 2019
@alexeagle alexeagle requested review from a team as code owners March 27, 2019 04:41
@filipesilva
Copy link
Contributor

There's a bunch of errors in everything Bazel related:

ERROR: /home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/external/bazel_toolchains/configs/ubuntu16_04_clang/1.1/bazel_0.21.0/default/BUILD:57:1: @bazel_toolchains//configs/ubuntu16_04_clang/1.1/bazel_0.21.0/default:cc-compiler-k8: no such attribute 'dynamic_runtime_libs' in 'cc_toolchain' rule
ERROR: /home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/external/bazel_toolchains/configs/ubuntu16_04_clang/1.1/bazel_0.21.0/default/BUILD:57:1: @bazel_toolchains//configs/ubuntu16_04_clang/1.1/bazel_0.21.0/default:cc-compiler-k8: no such attribute 'static_runtime_libs' in 'cc_toolchain' rule
ERROR: /home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/external/bazel_toolchains/configs/ubuntu16_04_clang/1.1/bazel_0.21.0/default/BUILD:85:1: @bazel_toolchains//configs/ubuntu16_04_clang/1.1/bazel_0.21.0/default:cc-compiler-armeabi-v7a: no such attribute 'dynamic_runtime_libs' in 'cc_toolchain' rule
ERROR: /home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/external/bazel_toolchains/configs/ubuntu16_04_clang/1.1/bazel_0.21.0/default/BUILD:85:1: @bazel_toolchains//configs/ubuntu16_04_clang/1.1/bazel_0.21.0/default:cc-compiler-armeabi-v7a: no such attribute 'static_runtime_libs' in 'cc_toolchain' rule
INFO: Repository 'org_brotli' used the following cache hits instead of downloading the corresponding file.
 * Hash '774b893a0700b0692a76e2e5b7e7610dbbe330ffbe3fe864b4b52ca718061d5a' for https://github.com/google/brotli/archive/v1.0.5.zip
If the definition of 'org_brotli' was updated, verify that the hashes were also updated.
ERROR: /home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/external/bazel_toolchains/configs/ubuntu16_04_clang/1.1/bazel_0.21.0/default/BUILD:57:1: Target '@bazel_toolchains//configs/ubuntu16_04_clang/1.1/bazel_0.21.0/default:compiler_deps' contains an error and its package is in error and referenced by '@bazel_toolchains//configs/ubuntu16_04_clang/1.1/bazel_0.21.0/default:cc-compiler-k8'
ERROR: /home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/external/bazel_toolchains/configs/ubuntu16_04_clang/1.1/bazel_0.21.0/default/BUILD:57:1: Target '@bazel_toolchains//configs/ubuntu16_04_clang/1.1/bazel_0.21.0/default:empty' contains an error and its package is in error and referenced by '@bazel_toolchains//configs/ubuntu16_04_clang/1.1/bazel_0.21.0/default:cc-compiler-k8'
ERROR: /home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/external/bazel_tools/tools/test/CoverageOutputGenerator/java/com/google/devtools/coverageoutputgenerator/BUILD:8:1: every rule of type java_binary implicitly depends upon the target '@bazel_toolchains//configs/ubuntu16_04_clang/1.1/bazel_0.21.0/default:toolchain', but this target could not be found because of: Target '@bazel_toolchains//configs/ubuntu16_04_clang/1.1/bazel_0.21.0/default:toolchain' contains an error and its package is in error
ERROR: /home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/external/bazel_tools/tools/test/CoverageOutputGenerator/java/com/google/devtools/coverageoutputgenerator/BUILD:8:1: Target '@bazel_tools//tools/test/CoverageOutputGenerator/java/com/google/devtools/coverageoutputgenerator:Main' depends on toolchain '@bazel_toolchains//configs/ubuntu16_04_clang/1.1/bazel_0.21.0/default:cc-compiler-k8', which cannot be found: Target '@bazel_toolchains//configs/ubuntu16_04_clang/1.1/bazel_0.21.0/default:cc-compiler-k8' contains an error and its package is in error'
ERROR: Analysis of target '//tools/public_api_guard:upgrade_api' failed; build aborted: Analysis failed

The main ones seem to be:

  • ERROR: /home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/external/bazel_toolchains/configs/ubuntu16_04_clang/1.1/bazel_0.21.0/default/BUILD:57:1: @bazel_toolchains//configs/ubuntu16_04_clang/1.1/bazel_0.21.0/default:cc-compiler-k8: no such attribute 'dynamic_runtime_libs' in 'cc_toolchain' rule
  • ERROR: /home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/external/bazel_toolchains/configs/ubuntu16_04_clang/1.1/bazel_0.21.0/default/BUILD:57:1: @bazel_toolchains//configs/ubuntu16_04_clang/1.1/bazel_0.21.0/default:cc-compiler-k8: no such attribute 'static_runtime_libs' in 'cc_toolchain' rule

It looks like we need to add a missing toolchain. I assume this is the toolchain that was removed in order to make Bazel smaller?

@alexeagle
Copy link
Contributor Author

caretaker assist: the codefresh status here was experimental, we've since disabled that check for PRs

@alexeagle alexeagle added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Mar 27, 2019
@mhevery mhevery closed this in aaa8a3a Mar 27, 2019
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019
@alexeagle @wKoza
build: update bazel to 0.24 (angular#29530)
94998a1 
PR Close angular#29530
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kyliau kyliau kyliau approved these changes

@filipesilva filipesilva filipesilva approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alexeagle @filipesilva @kyliau @googlebot